Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define discrete list of pubKeyCredParams algs #1843

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Define discrete list of pubKeyCredParams algs #1843

merged 3 commits into from
Feb 8, 2023

Conversation

MasterKale
Copy link
Contributor

@MasterKale MasterKale commented Jan 25, 2023 •
edited by pr-preview bot

This PR adds a suggestion to RP's to define three algorithm ID's in pubKeyCredParams for the widest possible authenticator support. Quoting myself from comments I made in #1757:

I'd put -8 at the top of the list to encourage adoption of Ed25519, since authenticators that can support it will choose to use it if it's first on the list (in my experience this is basically YubiKey 5's, but I think SoloKeys support it too). After that -7 and -257 are the two that practically cover almost 100% of existing authenticators.

Fixes #1757.

Preview | Diff

MasterKale
MasterKale commented Jan 26, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
emlun
emlun reviewed Jan 26, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
emlun
emlun approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MasterKale MasterKale merged commit 7e69437 into main Feb 8, 2023
@MasterKale MasterKale deleted the 1757-pubkeycredparams-update branch February 8, 2023 20:08
github-actions bot added a commit that referenced this pull request Feb 8, 2023
@MasterKale @github-actions
Merge pull request #1843 from w3c/1757-pubkeycredparams-update
20915f2 
SHA: 7e69437
Reason: push, by MasterKale

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zacknewman zacknewman mentioned this pull request Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlun emlun emlun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Which "pubKeyCredParams" to use?
2 participants
@MasterKale @emlun