New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the "Easily accessing credential data" fields in JSON. #1887
Conversation
The WebAuthn API provides accessors to get the SPKI-formatted public key and authenticator data without needing to parse CBOR or handle COSE. However, the JSON structures, prior to this change, didn't include these values giving users an unfortunate choice: either use the accessors and do the JSON encoding yourself, or use the provided `toJSON` function. But we can have both!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with or without the below suggestion.
Co-authored-by: Emil Lundberg <emil@yubico.com>
(from the call of 2023-05-17: good to merge when checks are happy.) |
I realize belatedly that we probably also need instructions on how to populate these new fields, like we have for Lines 1592 to 1602 in 6dfbdba
I'll open a follow-up PR. |
I'll fix the above issue in PR #1906. |
The WebAuthn API provides accessors to get the SPKI-formatted public key and authenticator data without needing to parse CBOR or handle COSE. However, the JSON structures, prior to this change, didn't include these values giving users an unfortunate choice: either use the accessors and do the JSON encoding yourself, or use the provided
toJSON
function.But we can have both!
Preview | Diff