-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove isPasskeyPlatformAuthenticatorAvailable() #1936
Conversation
Do we need to keep the passkey definition if we don't use the word? |
Agreed, it should be removed. |
If isPasskeyPlatformAuthenticatorAvailable() is going to be removed, we should also remove the definition of "passkey" that are recently introduced by the same PR1901, since "passkey" is not used in the specification after isPasskeyPlatformAuthenticatorAvailable() is removed. https://w3c.github.io/webauthn/#passkey Since the definition of "passkey" has a huge impact on marketing, we need to discuss with FIDO Alliance and make sure we have a consensus with their definition. PR1901: |
we shouldn't have any marketing elements at all in a technical specification. It's previously been raised that there are at least 4 different definitions of what a passkey is depending on who's marketing team you ask. |
PR #1923 gained a new |
Please keep the discussion on this PR, to the contents of this PR. This PR removes a method. Comments and feedback should be about that. If you'd like to propose other changes, please create a pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is technically accurate that this PR in isolation will leave the "passkey" terms unused, but this PR should be considered in combination with PR #1923 which as currently written would add new text referencing the terms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ready to merge pending resolution of the merge conflict (@timcappalli) |
# Conflicts: # index.bs
I took care of the merge conflict so it should be good to merge. |
This PR removes the
isPasskeyPlatformAuthenticatorAvailable()
method in favor of thegetClientCapabilities()
method defined in #1923.See issue #1937 for additional context.
Preview | Diff