-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove passkey word #1938
remove passkey word #1938
Conversation
from definition and changed Passkey platform authenticator to Discoverable platform authenticator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be abandoned as the term is referenced by other methods and should not be removed. There are also other changes in this PR that are not called out.
I don't see any actual justification in this PR for its removal. The justification for it being added in the first place is in the PR that was merged to add it and remains true. This seems to be more of a political move than constructive one.
#1936 provides no additional context here and you should raise an issue if this is to actually be discussed in earnest, not just piggybacked off of a sideline discussion in a different PR. If a FIDO representative or another member of the working group wants to make a novel and compelling case for its removal, I'd love to hear it either on the bi-weekly (soon to be weekly) call, at TPAC, or in a new issue. Preferably two out of three. |
There is a big confusion about what "passkeys" mean in the ecosystem. |
@maxhata consumer messaging is not in scope for this web platform API. |
Then why is "passkey" which is a consumer term contained within this standard? We already had a perfectly good terminology for discoverable keys. |
passkey is a noun, like password. Please see the original PR. |
Being a noun doesn't prevent it being a noun associated with consumer messaging, nor that the noun is confusing. |
As per advices, I'll hold this PR and raise a new issue. |
Closing as Issue #1939 was closed. |
This PR removes the word "passkey"
See PR #1936 for additional context.
+@maxhata
Preview | Diff