Clarify meaning of "unless" in UP flag validation #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you don't like how it's phrased, perhaps:
Of course "or" in natural language does not often mean what it does in logic (i.e., it can often mean mutual exclusivity), so you could phrase it like:
|
|
TBH, I think the original text makes more sense. |
MasterKale
approved these changes
Aug 21, 2024
MasterKale
reviewed
Aug 28, 2024
Comment on lines
+5638
to
+5640
| 1. Verify that the [=UP=] bit of the <code>[=flags=]</code> in |authData| is set. | ||
| If <code>|options|.{{CredentialCreationOptions/mediation}}</code> is set to {{CredentialMediationRequirement/conditional}}, | ||
| ignore this verification step. |
There was a problem hiding this comment.
What about something like this instead?
Suggested change
| 1. Verify that the [=UP=] bit of the <code>[=flags=]</code> in |authData| is set. | |
| If <code>|options|.{{CredentialCreationOptions/mediation}}</code> is set to {{CredentialMediationRequirement/conditional}}, | |
| ignore this verification step. | |
| 1. If <code>|options|.{{CredentialCreationOptions/mediation}}</code> is not set to {{CredentialMediationRequirement/conditional}}, verify that the [=UP=] bit of the <code>[=flags=]</code> in |authData| is set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2122.
I'm not entirely convinced about the "ignore this" part being a completely separated sentence, but I chose to formulate it this way to emphasize that by default the
UPflag should be verified, and only in exceptional circumstances should this verification be ignored.Preview | Diff