-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify meaning of "unless" in UP flag validation #2126
base: main
Are you sure you want to change the base?
Conversation
If you don't like how it's phrased, perhaps:
Of course "or" in natural language does not often mean what it does in logic (i.e., it can often mean mutual exclusivity), so you could phrase it like:
|
TBH, I think the original text makes more sense. |
1. Verify that the [=UP=] bit of the <code>[=flags=]</code> in |authData| is set. | ||
If <code>|options|.{{CredentialCreationOptions/mediation}}</code> is set to {{CredentialMediationRequirement/conditional}}, | ||
ignore this verification step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like this instead?
1. Verify that the [=UP=] bit of the <code>[=flags=]</code> in |authData| is set. | |
If <code>|options|.{{CredentialCreationOptions/mediation}}</code> is set to {{CredentialMediationRequirement/conditional}}, | |
ignore this verification step. | |
1. If <code>|options|.{{CredentialCreationOptions/mediation}}</code> is not set to {{CredentialMediationRequirement/conditional}}, verify that the [=UP=] bit of the <code>[=flags=]</code> in |authData| is set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wfm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggested change.
Fixes #2122.
I'm not entirely convinced about the "ignore this" part being a completely separated sentence, but I chose to formulate it this way to emphasize that by default the
UP
flag should be verified, and only in exceptional circumstances should this verification be ignored.Preview | Diff