-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #668: Recommend RPs to verify UP and UV flags #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
a merge-from-master may resolve the build issue? The content of the proposed changes seem to expect that if the authnr performs user verification that it returns both UV & UP bits set. and if it performs only a user presence test then it returns only UP bit set. Has that been firmly decided? |
@equalsJeffH You're right in the case of the registration operation; and no, that hasn't been decided. Will fix. |
Updated so the UP/UV logic agrees with what the client does. @rlin1 please re-review, since the logic has changed. |
@emlun can you fix conflict and merge |
@emlun after you fix the conflicts can you please want a day before merging? I'd like to review what the actual changes are, which are currently nearly impossibly to discern because of all the numbering changes. Thanks. |
@selfissued Will do. |
@selfissued I'll go ahead and merge this if you don't object by 2018-02-09 09:00Z. |
This resolves #668.
Preview | Diff