Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "with string-valued keys" to "whose keys are strings" #880

Merged
merged 1 commit into from
May 2, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Apr 24, 2018

This fixes #870.

This helps avoid confusion by reading "string-valued keys" as "keys mapped to values of string type".


Preview | Diff

This helps avoid confusion by reading "string-valued keys" as "keys
mapped to values of string type".
@emlun emlun added this to the PR milestone Apr 24, 2018
@emlun emlun self-assigned this Apr 24, 2018
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nadalin
Copy link
Contributor

nadalin commented May 1, 2018

@selfissued Please review and if approve merge

@selfissued selfissued merged commit 4f584b8 into master May 2, 2018
@emlun emlun deleted the issue-870-client-data-keys branch May 2, 2018 16:41
WebAuthnBot pushed a commit that referenced this pull request May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of CollectedClientData is outdated
4 participants