Add detailed design discussion for codec configuration #14
Conversation
steveanton
force-pushed
the
codec-configuration
branch
from
090f931
to
c878bea
Compare
|
I took a stab at updating the webidl.txt. To be honest, I wonder if trying to map everything to webidl might be more confusing than it's worth at this point. |
steveanton
force-pushed
the
codec-configuration
branch
from
c878bea
to
daccbea
Compare
| } | ||
|
|
||
| dictionary VideoEncoderOutput { | ||
| Uint8Array data; |
There was a problem hiding this comment.
I'm not sure it's good to switch from interfaces to dictionaries with (passive) data at this point. If we want to make efficient transformations that only look at the metadata (such as a layer-discarding filter), it may be better to leave the data as an accessor so that the case of passing frames unmodified can be handled without any data copying.
There was a problem hiding this comment.
This is already the case for the heavyweight resources (e.g., raw video frames) but not for bitstream contents. I think that discussion is outside the scope of this PR but would be valuable.
| timestamp: ..., | ||
| changeCodecSettings: { | ||
| targetBitRate: 50_000, | ||
| }, |
There was a problem hiding this comment.
Idea expressed in conversation: allow changing of codec settings even without a frame (WritableStream of either settings or video frame)
explainer.md
Outdated
| imageData: ..., | ||
| timestamp: ..., | ||
| frameSettings: { | ||
| forceKeyFrame: true, |
There was a problem hiding this comment.
Not all frames can be key frames, so should this be a "make the next available frame a key frame" dynamic codec setting? Or should we expect the user of the API to always be smart enough to time it right?
There was a problem hiding this comment.
I was already having difficulty identifying frame settings, so I'm just going to remove the category. We can add it back later if it turns out to have use.
steveanton
force-pushed
the
codec-configuration
branch
from
daccbea
to
c5bbe44
Compare
steveanton
force-pushed
the
codec-configuration
branch
from
c5bbe44
to
486dc9c
Compare
| timestamp: ..., | ||
| changeCodecSettings: { | ||
| targetBitRate: 50_000, | ||
| }, |
| } | ||
|
|
||
| dictionary VideoEncoderOutput { | ||
| Uint8Array data; |
There was a problem hiding this comment.
This is already the case for the heavyweight resources (e.g., raw video frames) but not for bitstream contents. I think that discussion is outside the scope of this PR but would be valuable.
explainer.md
Outdated
| imageData: ..., | ||
| timestamp: ..., | ||
| frameSettings: { | ||
| forceKeyFrame: true, |
There was a problem hiding this comment.
I was already having difficulty identifying frame settings, so I'm just going to remove the category. We can add it back later if it turns out to have use.
Addresses #5
PTAL @pthatcherg