Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing settings in frame chunks vs. separate chunks #20

Closed
steveanton opened this issue Sep 16, 2019 · 3 comments
Closed

Changing settings in frame chunks vs. separate chunks #20

steveanton opened this issue Sep 16, 2019 · 3 comments

Comments

@steveanton
Copy link
Contributor

As of #14 the mechanism for changing encoder settings is to bundle a dictionary with the input frame. An alternative discussed was to have a separate chunk type that only has changed settings (no input frame).

@steveanton
Copy link
Contributor Author

Pros/cons I could come up with:

Bundling setting changes with inputs:

Pros:

  • Obvious how it works with backpressure.

Cons:

  • Prevents settings from being changed early which could impact performance if the setting change requires some time.

Separate setting change chunks:

Pros:

  • Allows settings to be changed early without new input.

Cons:

  • Backpressure on setting change chunks doesn't really make sense.

@pthatcherg
Copy link
Contributor

I think this is should be addressed in the bigger issue at #35

@steveanton
Copy link
Contributor Author

I think these are two different issues. #20 here refers to dynamic settings which I believe do not have any objections to being in band. #35 refers to static settings which require a re-initialization. I would not be surprised if we support dynamic vs. static setting changes differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants