Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI job to check for warnings #216

Merged
merged 1 commit into from Jun 22, 2022
Merged

Add a CI job to check for warnings #216

merged 1 commit into from Jun 22, 2022

Conversation

jgraham
Copy link
Member

@jgraham jgraham commented May 25, 2022

This attempts a build and fails the job if there are any warnings.

@jgraham
Copy link
Member Author

jgraham commented May 25, 2022

https://github.com/w3c/webdriver-bidi/runs/6593026557?check_suite_focus=true#step:4:102 shows this failing as expected

@jgraham jgraham marked this pull request as ready for review May 25, 2022 13:33
@jgraham
Copy link
Member Author

jgraham commented May 25, 2022

Note that this depends on #194

@jgraham jgraham closed this May 25, 2022
@jgraham jgraham reopened this May 25, 2022
Base automatically changed from cddl_rust to master May 30, 2022 11:56
@jgraham jgraham closed this Jun 22, 2022
@jgraham jgraham reopened this Jun 22, 2022
@jgraham
Copy link
Member Author

jgraham commented Jun 22, 2022

The failure is #243

foolip
foolip approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI passes after rebase, then go!

@jgraham jgraham closed this Jun 22, 2022
@jgraham jgraham reopened this Jun 22, 2022
@jgraham jgraham closed this Jun 22, 2022
@jgraham jgraham reopened this Jun 22, 2022
@jgraham
Add a CI job to check for warnings
6b38eb7 
This attempts a build and fails the job if there are any warnings.
@jgraham jgraham merged commit 3ca8428 into master Jun 22, 2022
@jgraham jgraham deleted the die_on_warnings branch June 22, 2022 19:33
@whimboo whimboo added enhancement New feature or request infra Infrastructure related issues labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request infra Infrastructure related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgraham @foolip @whimboo