Add a timestamp to NavigationInfo #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that navigation events get a (wall clock) timestamp.
jgraham
force-pushed
the
navigation_timestamp
branch
from
b26b0c3
to
72d13bc
Compare
|
@sadym-chromium your review would be appreciated in case @foolip is still out. Thanks. |
Co-authored-by: Henrik Skupin <mail@hskupin.info>
sadym-chromium
approved these changes
Jan 3, 2023
github-actions bot
added a commit
that referenced
this pull request
Jan 3, 2023
SHA: cadc6b5 Reason: push, by jgraham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
We will get tests for this addition added via https://bugzilla.mozilla.org/show_bug.cgi?id=1790378. |
whimboo
added a commit
to whimboo/webdriver-bidi
that referenced
this pull request
Feb 3, 2023
This ensures that navigation events get a (wall clock) timestamp. Co-authored-by: Henrik Skupin <mail@hskupin.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that navigation events get a (wall clock) timestamp.
Preview | Diff