Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add userActivation parameter to script evaluation #496

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Add userActivation parameter to script evaluation #496

merged 3 commits into from
Jul 26, 2023

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jul 14, 2023 •
edited by pr-preview bot

Closes #359

Preview | Diff

@OrKoN OrKoN requested a review from mathiasbynens July 14, 2023 11:50
mathiasbynens
mathiasbynens reviewed Jul 14, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@OrKoN @mathiasbynens
Update index.bs
20634c2 
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
OrKoN
OrKoN commented Jul 14, 2023
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@OrKoN OrKoN requested a review from jgraham July 14, 2023 12:03
@OrKoN OrKoN mentioned this pull request Jul 18, 2023
Closed
jgraham
jgraham approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my understanding of user activation this seems reasonable.

@jgraham
Copy link
Member

jgraham commented Jul 26, 2023

I assume some tests will be written during implementation.

@jgraham jgraham merged commit 3eb2ec7 into main Jul 26, 2023
4 checks passed
@jgraham jgraham deleted the orkon/user-activation branch July 26, 2023 10:59
@OrKoN OrKoN mentioned this pull request Aug 2, 2023
Merged
@whimboo
Copy link
Contributor

whimboo commented Sep 22, 2023

@OrKoN was there a reason why the userActivation has only been added to script.evaluate but not script.callFunction?

@whimboo
Copy link
Contributor

whimboo commented Sep 25, 2023

@OrKoN was there a reason why the userActivation has only been added to script.evaluate but not script.callFunction?

That's my fault. It's there and I don't know why it was not found when I searched on the page. So it's all fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@jgraham jgraham jgraham approved these changes

@thiagowfx thiagowfx thiagowfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulating user gesture during script evaluation (script.evaluate, script.callFunction)
5 participants
@OrKoN @jgraham @whimboo @mathiasbynens @thiagowfx