Add "document" screenshots #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/formats
branch
from
f5ec682
to
52663ae
Compare
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
from
b68cab9
to
bc0e064
Compare
jrandolf
force-pushed
the
jrandolf/formats
branch
from
52663ae
to
113a35b
Compare
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
2 times, most recently
from
8f6d9f5
to
92db245
Compare
jrandolf
force-pushed
the
jrandolf/formats
branch
from
113a35b
to
572ce95
Compare
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
2 times, most recently
from
6f504b0
to
fb333b9
Compare
OrKoN
approved these changes
Sep 29, 2023
jrandolf
force-pushed
the
jrandolf/formats
branch
from
572ce95
to
32b86c5
Compare
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
from
fb333b9
to
7017856
Compare
jrandolf
force-pushed
the
jrandolf/formats
branch
3 times, most recently
from
08a647e
to
dd89c4a
Compare
|
@jrandolf could you please resolve conflicts? |
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
from
7017856
to
71100de
Compare
jgraham
requested changes
Oct 6, 2023
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
from
71100de
to
861443c
Compare
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
2 times, most recently
from
c09b525
to
2d0aa39
Compare
jgraham
reviewed
Oct 9, 2023
jgraham
requested changes
Oct 9, 2023
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
from
2d0aa39
to
3d08940
Compare
jrandolf
force-pushed
the
jrandolf/document-screenshot
branch
2 times, most recently
from
3d08940
to
e05f5d6
Compare
jgraham
approved these changes
Oct 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 12, 2023
SHA: a3a09be Reason: push, by jrandolf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@jrandolf please add WPT tests for this (and also for formats) |
whimboo
reviewed
Oct 16, 2023
We will take care of fullpage screenshot tests over on https://bugzilla.mozilla.org/show_bug.cgi?id=1840999. |
|
Oh, I've created the PR for the tests here: web-platform-tests/wpt#42804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements document screenshots (formerly called "fullscreen screenshots").
Issue #384
Preview | Diff