Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to start a session directly with the bidi connection #99

Merged
merged 10 commits into from
Sep 22, 2021
Merged

Add the ability to start a session directly with the bidi connection #99

merged 10 commits into from
Sep 22, 2021

Commits on Sep 22, 2021

  1. Sort WebDriver spec references

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e28275a View commit details
    Browse the repository at this point in the history

  2. Add the ability to start a session directly with the bidi connection 

    The case for this is:

* Some clients might be uninterested in using the classic WebDriver
HTTP connection, and want to avoid depending on a HTTP client just for
session creation.

* Some implementations might ship the HTTP server as a seperate
component, but have the bidi connection built-in to the browser
itself. This will allow clients to use bidi without a seperate driver
binary (similar to devtools) without requiring the browser to ship a
full HTTP implementation just for new session.

* It is needed to "explain" the behaviour of classic WebDriver in
terms of the BiDI protocol; in particular the new session and session
status command.

Implementation-wise the model is that a remote end is allowed to start
a WebSockets server that accepts connections to the `/session`
resource. This connection can then be used for "static" commands
i.e. those which don't require a session. Currently this is just
`session.status` and `session.new`. Once `session.new` is called, the
same WS connection is reused for subsequent commands that are part of
the session.
    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b420482 View commit details
    Browse the repository at this point in the history

  3. Update session creation to match WebDriver changes

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e194cb2 View commit details
    Browse the repository at this point in the history

  4. Remove session state that isn't used by BiDi sessions

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    0d9942d View commit details
    Browse the repository at this point in the history

  5. Make emitting events work with an explicit session

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    8c80931 View commit details
    Browse the repository at this point in the history

  6. Make the object serialization per session

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e076dbe View commit details
    Browse the repository at this point in the history

  7. Remove current session from the spec

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    c050ca5 View commit details
    Browse the repository at this point in the history

  8. Update navigation for session changes

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    9eb5076 View commit details
    Browse the repository at this point in the history

  9. Add new references to WebDriver spec

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    ed0e4c8 View commit details
    Browse the repository at this point in the history

  10. Allow multiple connections per session

    @jgraham
    jgraham committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    495cce0 View commit details
    Browse the repository at this point in the history