Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for file uploads (separate out from Element Send Keys) #1355

Open
whimboo opened this issue Nov 7, 2018 · 2 comments
Open

Add command for file uploads (separate out from Element Send Keys) #1355

whimboo opened this issue Nov 7, 2018 · 2 comments

Comments

@whimboo
Copy link
Collaborator

whimboo commented Nov 7, 2018

This is a request which came up during discussions on issue #1230. Especially due to broken behavior of drivers when it comes to hidden file upload input elements.

As agreed during TPAC (minutes) the proposal from @andreastt should be implemented. For details see #1230 (comment)

@andreastt
Copy link
Member

andreastt commented Nov 7, 2018

@burg had a request over in #1268 about adding a duplicate file check to Element Send Keys. @whimboo asked if we wanted to still add that to Element Send Keys, and I suspect the answer is that we don’t.

But adding a check for duplicate files to the new file upload command seems like a unanimously good idea, whilst also not breaking any backwards compatibility with Element Send Keys.

We can have this two ways:

  1. Return an error when the remote end discovers two of the files have identical paths.

  2. Deduplicate duplicate path entries.

@etanol
Copy link

etanol commented Mar 15, 2019

Quick question. Is this about adding a new /session/{id}/file endpoint to be able to attach files in remote WebDriver sessions? Like what ChromeDriver supports for this non-W3C endpoint.

Imagine the WebDriver client is running in host A and the server in host B. Making the browser in host B upload a file (as in <input type="file">) that is in host A is quite cumbersome without the file endpoint.

Should I open a different issue for such a request?

Thanks.

OndraM added a commit to OndraM/php-webdriver that referenced this issue Nov 23, 2019
OndraM added a commit to OndraM/php-webdriver that referenced this issue Nov 23, 2019
bestlucky0825 added a commit to bestlucky0825/php-webdriver that referenced this issue May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants