Explicitly require navigation actions to end with top-level context. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<p class=note>Navigation actions - Get, Back, Forward, Refresh - always, unless they abort the navigation, complete with the <a>current top-level browsing context</a> being the <a>current browsing context</a>. Even if we navigate Back or Forward to a state where a different <a href=https://html.spec.whatwg.org/#browsing-context>browsing context</a> was the <a>current browsing context</a>. Alternative behavior *could* be for the remote end to "remember" what was the <a>current browsing context</a> at each of the state of the "history". I don't support that behavior because I believe it is more complex in implementation ([speculating] other than WebDriver, browser components don't seem to already define the notion of the <a>current browsing context</a> so WebDriver would have to "remember" those for itself [/speculating]). This suggestion was prompted by the regression (in this yet unspecified behavior) in chrome/chromedriver: https://code.google.com/p/chromedriver/issues/detail?id=1106
| <a>current top-level browsing context</a> as if <a>Switch to Frame</a> | ||
| command was executed with no specified | ||
| <a href="https://html.spec.whatwg.org/#child-browsing-context"> | ||
| child browsing context</a>. |
There was a problem hiding this comment.
I don’t think we should make a reference to Switch To Frame at all here. If we need some generalised prose related to resetting the current browsing context we should add that as a definition, but I don’t think we do.
There was a problem hiding this comment.
Agreed,
" as if Switch to Frame
command was executed with no specified
child browsing context"
can be removed completely. I can update this PR when the other comment in this PR is resolved.
|
I believe this is mostly replaced by #275. |
|
@AutomatedTester I believe this can now be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation actions - Get, Back, Forward, Refresh - always, unless they abort the navigation, complete with the current top-level browsing context being the current browsing context. Even if we navigate Back or Forward to a state where a different browsing context was the current browsing context.
Alternative behavior could be for the remote end to "remember"
what was the current browsing context at each of the state
of the "history". I don't support that behavior because I believe
it is more complex in implementation
([speculating] other than WebDriver, browser components don't seem
to already define the notion of the current browsing context
so WebDriver would have to "remember" those for itself [/speculating]).
This suggestion was prompted by the regression (in this yet unspecified behavior)
in chrome/chromedriver:
https://code.google.com/p/chromedriver/issues/detail?id=1106