Clarify that noProxy expects a list of comma-separated entries. #1044
Conversation
|
@whimboo is a Mozilla employee, which is a w3c member organisation. |
|
@shs96c I got my account validated and connected it to Github. Looks like we are set for a review now. |
| @@ -1986,8 +1986,9 @@ <h2 data-dfn-for="NavigatorAutomationInformation">Interface</h2> | |||
| <tr> | |||
| <td><dfn><code>noProxy</code></dfn> | |||
| <td>array | |||
| <td>Lists the address for which the proxy should be bypassed when | |||
| the <a><code>proxyType</code></a> is "<code>manual</code>". | |||
| <td>Comma-separated list of hosts for which the proxy should be bypassed if | |||
There was a problem hiding this comment.
The Valid Values column tells us that this is not a comma-separated list, but a JSON List type:
A List containing any number of any of domains, IPv4 addresses, or IPv6 addresses.
If the driving force behind this is to make the implementation less fussy (for example, just a String that the implementation can do what it wants with), then you also need to modify the Valid Value column.
There was a problem hiding this comment.
Oh, so it means we are requiring something like {"noProxy": ["foo.bar", "127.0.0.1"]}?
With that the different driver implementations would have to join all entries into a single string with a separator the browser supports. I would be fine with that, and would update the PR to only make this entry sound similar to proxyAutoconfigUrl.
There was a problem hiding this comment.
@shs96c any further feedback? If the last comment applies to how it should look like, we can close this issue. Or should we mention "JSON list" similar to other parts of the spec?
There was a problem hiding this comment.
Yes, the spec is saying that we should have something like {"noProxy": ["foo.bar"]}
There was a problem hiding this comment.
So should we update to say "JSON list"? I can update my PR appropriately.
|
Closing this PR, as @whimboo requested. The spec is sufficiently clear. |
|
@shs96c so no need to make it a "JSON List" what is the term we use at other places? |
|
It already says that the valid input is a JSON List? |
|
Yes. Under
With |
This change is