Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop styling null and undefined types #1075

Merged
merged 1 commit into from Aug 31, 2017
Merged

stop styling null and undefined types #1075

merged 1 commit into from Aug 31, 2017

Conversation

andreastt
Copy link
Member

@andreastt andreastt commented Aug 30, 2017

In specifications we want to compare ourselves with, null and undefined
are not given a special tag. Null and undefined types are no
different to strings or arrays.


This change is Reviewable

@shs96c
Copy link
Contributor

shs96c commented Aug 31, 2017

I'm unsure about this. Although the other specs may not highlight them, both null and undefined are values, and we are styling values. They are different from String and Array, as those are both types (as @jgraham pointed out on IRC, the associated types are Null and Undefined)

In specifications we want to compare ourselves with, null and undefined
are not given a special <code> tag.  Null and undefined types are no
different to strings or arrays.
@andreastt
Copy link
Member Author

At the moment we use the computing science terminology of null and undefined interchangeably with the JSON types. If you wanted to be super-correct here you would want to distinguish between nulls and undefineds used internally for algorithms and those passed in as input or emitted as output.

In any case we are referencing the JSON definitions of both where it matters, which we also do for String and Array. I can certainly go through the specification and add plumbing to allow internal-nulls and internal-undefineds to be implicitly coerced to JSON Nulls and Undefineds when a response is being sent, as well as fix s/null/Null and s/undefined/Undefined/ where that matters for output?

@shs96c
Copy link
Contributor

shs96c commented Aug 31, 2017

Let's look like everyone else for now.

@shs96c shs96c merged commit 5e45a35 into w3c:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants