Updating prompt handling during user script to be consistent #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section 18 of the spec states that, "When a user prompt appears, it is the task of the subsequent command to handle it." The algorithm for "Executing a function body" (Section 15.2) violates this statement, insisting that the user prompt handler be invoked during the current command, rather than by the subsequent command. Instead, we should immediately abort the execute[Async]Script command, and let the subsequent command handle the user prompt, if any.
jimevans
requested review from
andreastt,
AutomatedTester,
jgraham and
shs96c
as code owners
andreastt
reviewed
Apr 10, 2018
webdriver-spec.html
Outdated
| @@ -1,4 +1,4 @@ | |||
| <!doctype html> | |||
| <!doctype html> | |||
There was a problem hiding this comment.
I can’t tell from the raw patch what has actually changed here.
There was a problem hiding this comment.
It’s probably the UTF-8 byte marker from the editor I was using, since it’s at the very beginning of the file. I can fix that up if need be, I suppose.
There was a problem hiding this comment.
Yeah, we don’t want a BOM there.
There was a problem hiding this comment.
Removed in subsequent commit.
|
Test PR located at web-platform-tests/wpt#10401 |
andreastt
approved these changes
Apr 10, 2018
|
Spec change and tests look good to me, but it would be good if someone from another vendor and an editor would look at this before continue. |
AutomatedTester
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE This PR is intended to spark discussion. It touches on at least two issues already filed against the spec (#1153 and #1135), and should be considered, since user prompt handlers was largely removed from the Level 1 specification.
Section 18 of the spec states that, "When a user prompt appears, it is
the task of the subsequent command to handle it." The algorithm for
"Executing a function body" (Section 15.2) violates this statement,
insisting that the user prompt handler be invoked during the current
command, rather than by the subsequent command. Instead, we should
immediately abort the execute[Async]Script command, and let the subsequent
command handle the user prompt, if any.
Preview | Diff