Element Click and Element Clear need to handle user prompts (#1191) #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested review from
andreastt,
AutomatedTester,
jgraham and
shs96c
as code owners
|
@whimboo: there's a merge conflict, but once that's fixed, this is good to go. |
|
It also requires tests. |
|
Yes, as mentioned in the initial comment tests will be added with https://bugzilla.mozilla.org/show_bug.cgi?id=1473814 soon. I will rebase to solve the conflict soon. |
|
As it looks like I was on an old revision which haven't had the webdriver-spec.html forwarding to index.html. I updated my PR to make it apply correctly. |
|
My patch for the tests has been landed on mozilla-autoland. Can someone please review and merge this PR? Thanks |
|
The open wpt-sync PR: web-platform-tests/wpt#13232 |
AutomatedTester
previously approved these changes
Sep 27, 2018
|
@whimboo this has merge conflicts, please rebase |
|
@AutomatedTester As the box above tells me there are no conflicts with the base branch. So what are you referring to? |
whimboo
force-pushed
the
user_prompt_elements
branch
from
21d0de8
to
678bfb6
Compare
AutomatedTester
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1191. @shs96c mind reviewing this change?
Tests will be written via https://bugzilla.mozilla.org/show_bug.cgi?id=1473814.
Thanks.
Preview | Diff