Fix issues with User Prompt Handler after PR #1791 #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
requested changes
May 17, 2024
whimboo
force-pushed
the
prompt_handler
branch
2 times, most recently
from
1a27a9d
to
e4007c6
Compare
jgraham
approved these changes
May 21, 2024
|
@OrKoN mind a quick review as well? Thanks a lot. |
OrKoN
reviewed
May 21, 2024
github-actions bot
added a commit
to xjc90s/webdriver
that referenced
this pull request
May 22, 2024
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #1791 we got extended support for the
unhandledPromptBehaviorlanded which added a new Object type to define handlers for all the prompt handlers more granularly.While implementing the capability handling for that new type in Firefox I noticed a couple of issue. This PR fixes these and also updates some cases to make it better understandable what specific variables actually are.
FYI @sadym-chromium @nechaev-chromium @gsnedders for when you get started to implement these changes in the drivers.
Updated tests will be part of my work on https://bugzilla.mozilla.org/show_bug.cgi?id=1895738.
Preview | Diff