Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json work #585

Closed
wants to merge 3 commits into from
Closed

Json work #585

wants to merge 3 commits into from

Conversation

AutomatedTester
Copy link
Contributor

@AutomatedTester AutomatedTester commented Jan 19, 2017

This change is Reviewable

@shs96c
Copy link
Contributor

shs96c commented Jan 19, 2017

Can we break this into the Americanisation of spellings and then a follow up with changes to how serialisation is done?

@shs96c shs96c modified the milestone: Level 1 Jan 19, 2017
@andreastt
Copy link
Member

Also, can we please avoid capitalisation in JSON serialization? The style in the rest of the document is to use a capital letter only if the definition starts a new sentence.

@shs96c
Copy link
Contributor

shs96c commented Jan 20, 2017

You need to rebase. Once you've addressed @andreastt's comment about capitalisation, ship it!

@jgraham
Copy link
Member

jgraham commented Jan 20, 2017

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


webdriver-spec.html, line 674 at r1 (raw file):

<p>The result of <dfn>JSON serialization</dfn> with <var>object</var> of type JSON <a>Object</a>
  and calling the <a>[[\Stringify]]</a> method on <var>object</var>.

I think you mean the <a>Stringify</a> function with argument <var>object</var>.


webdriver-spec.html, line 677 at r1 (raw file):

<p>The result of <dfn>JSON deserialization</dfn> with <var>text</var> is defined as
  the result of calling the <a>[[\Parse]]</a> method.

Surely this needs an argument?

Also the function isn't correctly referred to as a "method".


Comments from Reviewable

@AutomatedTester
Copy link
Contributor Author

landed in

webdriver/master 3e0666e AutomatedTester: Define the algorithm for JSON Serialization
webdriver/master f121c53 AutomatedTester: Correct spelling of serialization to en-US
webdriver/master 835f2cb AutomatedTester: Define JSON Deserialization

@AutomatedTester AutomatedTester deleted the json_work branch March 7, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants