Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated Section for Ad-Insertion #28

Closed
thasso opened this issue Aug 28, 2017 · 4 comments
Closed

Create a dedicated Section for Ad-Insertion #28

thasso opened this issue Aug 28, 2017 · 4 comments
Assignees
@thasso

Comments

@thasso
Copy link
Contributor

thasso commented Aug 28, 2017

As mentioned in #19, we should maybe consolidate all Ad-Insertion related topics in one section?
@thasso thasso self-assigned this Aug 28, 2017
@joelkorpi
Copy link
Contributor

Agree. Maybe let's move it to section 3?

@joelkorpi joelkorpi mentioned this issue Aug 28, 2017
Closed
@joelkorpi
Copy link
Contributor

@thasso Where did we end up on this? Are you going to move these sections?

thasso added a commit that referenced this issue Aug 31, 2017
@thasso
Refactored ad insertion sections for #28
2379212
thasso added a commit that referenced this issue Aug 31, 2017
@thasso
Refactored ad insertion sections for #28
b58ef28
@thasso
Copy link
Contributor Author

thasso commented Aug 31, 2017

I created PR #33 with this. I did follow you suggestion and moved it to section 3

joelkorpi added a commit that referenced this issue Sep 1, 2017
@joelkorpi
Merge pull request #33 from w3c/ad-insertions
d501c26 
Merged Ad-insertion sections for #28
@joelkorpi
Copy link
Contributor

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thasso thasso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thasso @joelkorpi