Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: Update → Add as the verb used when adding new IDL files #23

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 25, 2018

This was copypasta, the whole point of the verb argument was to allow for this
distinction.

Fixes #22.

This was copypasta, the whole point of the verb argument was to allow for this
distinction.

Fixes #22.
Copy link
Member Author

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewing this and will merge (if possible) since it's trivial and I'd like to see if it works :)

@foolip
Copy link
Member Author

foolip commented Sep 25, 2018

Oops, looks like we're running Travis for PRs in a way that'll touch the real branches and PRs. Should fix that before it messes something up.

@foolip
Copy link
Member Author

foolip commented Sep 25, 2018

Filed #24 and turning off Travis for PRs.

@foolip foolip merged commit ad4d9b2 into master Sep 25, 2018
@foolip foolip deleted the typo-update-add branch September 25, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant