Define an RTCIceCandidate match algorithm. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: w3c#186. The algorithm matches the (non-derived) candidate, sdpMid, sdpMLineIndex, and usernameFragment attributes of RTCIceCandidate. The candidate match algorithm will be used in the candidate pair match algorithm (w3c#187), which will, in turn, be used in validation steps for RTCIceTransport methods (w3c#188).
Break down long and complex lines into individual steps.
|
This algorithm is referenced by the candidate-pair match algorithm (#193), which will be used in validation steps for various RTCIceTransport algorithms (#194). This algorithm is a more lenient approach to candidate matching as compared to object equality, as suggested by w3c/webrtc-pc#2906. If various RTCIceCandidate values are indeed made object-comparable, this PR is unnecessary and the candidate-pair match algorithm can simply test object equality instead. The wording of the algorithm is based on the codec match algorithm. Separate steps are needed in the algo for checking |
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 10, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 10, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
jan-ivar
approved these changes
Jan 11, 2024
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 12, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
sam-vi
added a commit
to sam-vi/webrtc-extensions
that referenced
this pull request
Jan 12, 2024
This depends on several other PRs to be merged first: - w3c#170: Addition of removeCandidatePair method - w3c#192: Definition of candidate match algo - alternately, w3c/webrtc-pc#2906 to enforce RTCIceCandidate object equality - w3c#193: Definition of candidate pair match algo - w3c#194: Addition of CandidatePairs internal slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #186.
The algorithm matches the (non-derived) candidate, sdpMid, sdpMLineIndex, and usernameFragment attributes of RTCIceCandidate.
The candidate match algorithm will be used in the candidate pair match algorithm (#187), which will, in turn, be used in validation steps for RTCIceTransport methods (#188).
Preview | Diff