Are various exposed RTCIceCandidate values object-comparable?

[jan-ivar]

Would you expect two calls of getLocalCandidates() to return the same objects? Two calls of getSelectedCandidatePair()?

iceTransport.getLocalCandidates()[0] == iceTransport.getLocalCandidates()[0] // true?
iceTransport.getSelectedCandidatePair().local == iceTransport.getSelectedCandidatePair().local; // true?

Probably. What about across the two?

iceTransport.getLocalCandidates().includes(iceTransport.getSelectedCandidatePair().local) // true?

Probably. What about the candidates exposed in events?

pc.onicecandidate = e => console.log(iceTransport.getLocalCandidates().includes(e.candidate)); // true?

Probably there too. This fiddle shows a mixed bag in Chrome, showing true in the first case, and false thereafter.

It's probably not too late to tighten this up, and get true for all of them. This will simplify w3c/webrtc-extensions#175.

Solution

Other than its constructor, the surface a candidate algorithm is the only place that creates an RTCIceCandidate:

The phrase "transport's set of candidates" looks it it should be a linkable concept, suggesting the intent here was to keep track of these objects. We should probably make this more explicit with an internal slot that the getters refer to.