Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of handling iceCandidatePoolSize in setConfiguration is out of sync with JSEP #1049

Closed
taylor-b opened this issue Mar 3, 2017 · 0 comments

Comments

@taylor-b
Copy link
Contributor

taylor-b commented Mar 3, 2017

In JSEP, we decided that changing the candidate pool size is only allowed before setLocalDescription is called, and as a consequence, the pool will only be used for the first offer/answer exchange.

But webrtc-pc currently has a step in setConfiguration that says simply:

Set the ICE Agent's prefetched ICE candidate pool size as defined in [JSEP] to the value of configuration.iceCandidatePoolSize. If the new ICE candidate pool size changes the existing setting, this may result in immediate gathering of new pooled candidates, or discarding of existing pooled candidates, as defined in [JSEP].

... Which doesn't say what to do if setLocalDescription has already been called.

I'd suggest throwing an InvalidModificationError like we do for everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants