Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw InvalidModificationError if changing pool size after SLD. #1054

Merged
merged 1 commit into from Mar 9, 2017

Conversation

taylor-b
Copy link
Contributor

@taylor-b taylor-b commented Mar 3, 2017

Fixes #1049.

@taylor-b taylor-b force-pushed the issue_1049_icecandidatepoolsize branch from 84da560 to 5a48a82 Compare March 7, 2017 00:02
@aboba
Copy link
Contributor

aboba commented Mar 8, 2017

@taylor-b Since we don't allow connection.peerIdentity, certificates, bundlePolicy or rtcpMuxPolicy to be changed (regardless of whether setLocalDescription has been called yet), it might be simpler just to prohibit changing the iceCandidatePoolSize.

@taylor-b
Copy link
Contributor Author

taylor-b commented Mar 8, 2017

@aboba That was my initial thought, but there are some potential situations where changing the size before SLD is desirable. For example, an application may want to create a PeerConnection as early as possible for various reasons, but only set the candidate pool size when a "call" is imminent, since setting it too early would result in STUN/TURN candidates that need to be kept alive. So, this is what the JSEP editors ended up going with.

@aboba
Copy link
Contributor

aboba commented Mar 8, 2017

Makes sense.

@alvestrand alvestrand merged commit e5f5633 into w3c:master Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants