Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section 9.6: protocol type #1293

Closed
aboba opened this issue May 31, 2017 · 2 comments
Closed

Section 9.6: protocol type #1293

aboba opened this issue May 31, 2017 · 2 comments
Assignees
@aboba
Labels
PR exists

Comments

@aboba
Copy link
Contributor

aboba commented May 31, 2017

From EKR: https://lists.w3.org/Archives/Public/public-webrtc/2017May/0166.html

Is there any valid reason to allow the protocol to be a DOMString as
opposed to ASCII or LDH? It's about to be shoved into a URL...
@aboba
Copy link
Contributor Author

aboba commented Aug 17, 2017

In terms of WebIDL types, we only have DOMString, ByteString and USVString.

aboba added a commit that referenced this issue Aug 17, 2017
@aboba
protocol can only contain ASCII
5c3f6b3 
Fix for Issue #1293
@aboba aboba assigned aboba and unassigned dontcallmedom Aug 17, 2017
@aboba aboba mentioned this issue Aug 17, 2017
Merged
@aboba
Copy link
Contributor Author

aboba commented Aug 21, 2017

RFC 3986 defines the syntax. As noted in Section 2.3, unreserved characters include ALPHA / DIGIT / "-" / "." / "_" / "~"

@aboba aboba closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboba aboba

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dontcallmedom @aboba