Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checking for selectorArg in getStats is unnecessary #1498

Closed
soareschen opened this issue Jul 20, 2017 · 1 comment
Closed

Type checking for selectorArg in getStats is unnecessary #1498

soareschen opened this issue Jul 20, 2017 · 1 comment
Assignees
@aboba
Labels
PR exists

Comments

@soareschen
Copy link
Contributor

Step 3 of getStats:

If selectorArg is neither null nor a MediaStreamTrack, return a promise rejected with a newly created TypeError.

This is not needed as the type checking is already done by WebIDL.
@soareschen soareschen mentioned this issue Jul 20, 2017
Merged
@aboba aboba assigned soareschen and unassigned jan-ivar Jul 27, 2017
@aboba
Copy link
Contributor

aboba commented Jul 27, 2017

@soareschen Can you submit a PR?

aboba added a commit that referenced this issue Aug 17, 2017
@aboba
Type checking for selectorArg in getStats is unnecessary
b148800 
Fix for Issue #1498
@aboba aboba mentioned this issue Aug 17, 2017
Merged
@aboba aboba assigned aboba and unassigned soareschen Aug 17, 2017
@aboba aboba closed this as completed Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboba aboba

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soareschen @aboba @jan-ivar