New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify ICE consent freshness feedback #517
Comments
I think it is kind of obvious to use the RTCIceConnectionState to communicate the events. As RFC 7665 mandates that loosing consent after the 30s timer is permanent for a given pair translating loosing consent for a single component into the 'failed' state appears appropriate. |
@nils-ohlmeier can you check #457 to see if this is part of the same problem? @elagerway opinions? |
To some degree yes it is the same problem, as it also touches the same state diagram. Whether [CONSENT] final 30s timeout leads to 'failed' or to 'disconnected' (or 'checking' as proposed on the slides for the checking state) does not really matter to me. It just needs to be defined and written down. That should be easy. |
The outcome of each individual consent check should not be reflected in either RTCIceTransportState or RTCIceConnectionState, because there is nothing a developer can or should do about the failure of individual consent checks. Consent request/response statistics is another matter. My suggestion is that a consent failure in the "completed" state should cause a transition to "failed" for both RTCIceTransportState and RTCIceConnectionState. |
@nils-ohlmeier @alvestrand I have submitted RTCIceTransportState definitions that at least partially takes consent check failures into account: PR #533 |
Related to #457 |
Depends on #457 |
@nils-ohlmeier @taylor-b Can you review PR #611 ? |
In response to WebRTC 1.0 Issue w3c/webrtc-pc#517
When implementing RFC 7665 it is not very well defined how the different state transitions from that RFC get reported back through the PeerConnection APIs.
The text was updated successfully, but these errors were encountered: