Add RTCIceTransportState Enum #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add definitions for RTCIceTransport.state
Update the indentation.
| <dt>connected</dt> | ||
| <dd> | ||
| <p> | ||
| The <code><a>RTCIceTransport</a></code> has received found a usable connection |
Add statement that a consent check failure in "completed" causes a transition to "failed".
Added statement that a consent check failure in "connected" causes a transition to "disconnected".
|
@nils-ohlmeier Added clarifications responding to your comments. |
|
@taylor-b would mind taking a look and providing some comment here? |
|
I just made PR #557 which does what I talked about in the virtual interim: move the ICE state definitions into the RTCIceTransport section, and define RTCIceConnectionState in the same fashion that RTCPeerConnectionState is defined. Could we try to merge that PR before merging this one? That way, when viewing the diff for this one, it will be clear how the ICE state definitions are changing. My PR doesn't change the definitions, it just moves them around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add definitions for RTCIceTransport.state
Relates to Issue #457