Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review other uses of "stopped" #917

Closed
aboba opened this issue Nov 4, 2016 · 2 comments
Closed

Review other uses of "stopped" #917

aboba opened this issue Nov 4, 2016 · 2 comments

Comments

@aboba
Copy link
Contributor

aboba commented Nov 4, 2016

The following references to "stopped" RtpSender/RtpReceivers need to be reviewed:

  1. Definition of close():
    All RTCRtpSenders in senders are now considered stopped.
    All RTCRtpReceivers in receivers are now considered stopped.
    Could we instead set RTCRtpTransceiver.stopped to true?

  2. replaceTrack:
    If sender is stopped, return a promise rejected with an InvalidStateError.
    Could we instead test if transceiver.stopped is true?

  3. insertDTMF:
    If sender has been stopped, throw an InvalidStateError exception.
    If sender has been stopped, abort these steps.
    Could we test if transceiver.stopped is true or if transceiver.direction is recvonly?

@aboba aboba changed the title Review use of "stopped" Review other uses of "stopped" Nov 4, 2016
aboba added a commit that referenced this issue Nov 4, 2016
Partial fix for Issue #917
@taylor-b
Copy link
Contributor

taylor-b commented Nov 4, 2016

All those suggestions sound right to me. Though for insertDTMF, the direction could be "recvonly" or "inactive". And I assume it's really the SDP-negotiated direction that matters, not just the last value you passed into setDirection.

@aboba
Copy link
Contributor Author

aboba commented Nov 8, 2016

@taylor-b It makes sense to not allow insertDTMF on a sender that cannot send and I agree that we need the SDP-negotiated direction to determine this (or maybe encodings[].active??), not transceiver.direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants