-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review other uses of "stopped" #917
Comments
All those suggestions sound right to me. Though for |
@taylor-b It makes sense to not allow insertDTMF on a sender that cannot send and I agree that we need the SDP-negotiated direction to determine this (or maybe encodings[].active??), not transceiver.direction. |
The following references to "stopped" RtpSender/RtpReceivers need to be reviewed:
Definition of close():
All RTCRtpSenders in senders are now considered stopped.
All RTCRtpReceivers in receivers are now considered stopped.
Could we instead set RTCRtpTransceiver.stopped to true?
replaceTrack:
If sender is stopped, return a promise rejected with an InvalidStateError.
Could we instead test if transceiver.stopped is true?
insertDTMF:
If sender has been stopped, throw an InvalidStateError exception.
If sender has been stopped, abort these steps.
Could we test if transceiver.stopped is true or if transceiver.direction is recvonly?
The text was updated successfully, but these errors were encountered: