Remove "stopped" from close(), insertDTMF and replaceTrack #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue #917
|
@taylor-b Can you review? |
aboba
changed the title
taylor-b
suggested changes
Nov 11, 2016
| <code><a>CollectTransceivers</a></code> algorithm. For every | ||
| <code><a>RTCRtpTransceiver</a></code> <var>transceiver</var> in | ||
| <var>transceivers</var>, set | ||
| <code><var>transceiver</var>.stopped</code> to |
There was a problem hiding this comment.
This should probably point to the RTCRtpTransceiver.stop method, and not just set the attribute directly.
There was a problem hiding this comment.
Right. Among other things, that would make sure that transceiver.receiver.track.readyState gets set.
There was a problem hiding this comment.
I inserted steps from the stop() method.
Add steps to close each transceiver
aboba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Taylor's "currentDirection" PR (do not merge)
Fix for Issue #917