In data channel send(), remove unneeded conditions #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue #1396
|
Existing PR for the same Issue: #1398 |
taylor-b
approved these changes
Jun 20, 2017
lgrahl
added a commit
to lgrahl/ortc
that referenced
this pull request
Jun 30, 2017
Remove unneeded conditions. (w3c/webrtc-pc#1404) Throw an error if data channel's buffer is filled rather than implicit closing. (w3c/webrtc-pc#1209) Throw an error if len(message) > max-message-size of the remote peer (w3c/webrtc-pc#1209)
This was referenced Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #1396