-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace serializers by toJSON definitions #1449
Conversation
Using [Default] for RTCSessionDescription Using algorithm inspired by [WebIDL example](https://heycam.github.io/webidl/#tojson-example) for RTCIceCandidate This currently creates a warning in ReSpec, but [I don't think it should](https://github.com/w3c/respec/issues/1309) Also, this (implicitly) creates a dependency on WebIDL level 2 close #1419
no longer needed
webrtc.html
Outdated
<li>For each attribute identifier <var>attr</var> in "candidate", "sdpMid", "sdpMLineIndex", "description": | ||
<ol> | ||
<li>Let <var>value</var> be the result of getting the underlying value of the attribute identified by <var>attr</var>, given this <code>RTCIceCandidate</code> object.</li> | ||
<li>Set <var>json</var>[<var>attr</var>] to <var>value</var>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should json[attr]
be in a <code>
?
webrtc.html
Outdated
<dd>To invoke the <code>toJSON()</code> operation of the <code>RTCIceCandidate</code> interface, run the following steps: | ||
<ol> | ||
<li>Let <var>json</var> be a new <code>RTCIceCandidateInit</code> dictionary.</li> | ||
<li>For each attribute identifier <var>attr</var> in "candidate", "sdpMid", "sdpMLineIndex", "description": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This is missing the set-delineating markers («») from the WebIDL example
I get respec complaints on latest master now:
|
Using [Default] for RTCSessionDescription
Using algorithm inspired by WebIDL example for RTCIceCandidate
This currently creates a warning in ReSpec, but I don't think it should
Also, this (implicitly) creates a dependency on WebIDL level 2
close #1419
Preview | Diff