Replace serializers by toJSON definitions #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using [Default] for RTCSessionDescription Using algorithm inspired by [WebIDL example](https://heycam.github.io/webidl/#tojson-example) for RTCIceCandidate This currently creates a warning in ReSpec, but [I don't think it should](https://github.com/w3c/respec/issues/1309) Also, this (implicitly) creates a dependency on WebIDL level 2 close #1419
no longer needed
taylor-b
approved these changes
Jul 12, 2017
webrtc.html
Outdated
| <li>For each attribute identifier <var>attr</var> in "candidate", "sdpMid", "sdpMLineIndex", "description": | ||
| <ol> | ||
| <li>Let <var>value</var> be the result of getting the underlying value of the attribute identified by <var>attr</var>, given this <code>RTCIceCandidate</code> object.</li> | ||
| <li>Set <var>json</var>[<var>attr</var>] to <var>value</var>.</li> |
There was a problem hiding this comment.
nit: should json[attr] be in a <code>?
webrtc.html
Outdated
| <dd>To invoke the <code>toJSON()</code> operation of the <code>RTCIceCandidate</code> interface, run the following steps: | ||
| <ol> | ||
| <li>Let <var>json</var> be a new <code>RTCIceCandidateInit</code> dictionary.</li> | ||
| <li>For each attribute identifier <var>attr</var> in "candidate", "sdpMid", "sdpMLineIndex", "description": |
There was a problem hiding this comment.
nit: This is missing the set-delineating markers («») from the WebIDL example
|
I get respec complaints on latest master now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using [Default] for RTCSessionDescription
Using algorithm inspired by WebIDL example for RTCIceCandidate
This currently creates a warning in ReSpec, but I don't think it should
Also, this (implicitly) creates a dependency on WebIDL level 2
close #1419
Preview | Diff