Removing text talking about key shortening that was incorrect. #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#1156. The HMAC algorithm itself accepts *any* key size. So all we have to say here is that WebRTC allows any key size 20 bytes or greater (even if the implementation has transitioned to HMAC-SHA-256, and would prefer a 32-byte key for the added security).
|
Do you really want to say "MAY be any multiple of bytes greater than 20"? |
This was referenced Jul 10, 2017
aboba
added a commit
to w3c/ortc
that referenced
this pull request
Jul 25, 2017
Fix for Issue #701 Equivalent WebRTC 1.0 PR: w3c/webrtc-pc#1453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1156.
The HMAC algorithm itself accepts any key size. So all we have to say
here is that WebRTC allows any key size 20 bytes or greater (even if the
implementation has transitioned to HMAC-SHA-256, and would prefer a
32-byte key for the added security).
Preview | Diff