offerToReceive: s/transceiver type/transceiver kind/ (and do it for kinds, not mediaTypes) #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adam-be can you please take a look? |
jan-ivar
requested changes
Dec 6, 2017
webrtc.html
Outdated
| @@ -3314,7 +3314,7 @@ <h2>Attributes</h2> | |||
| </li> | |||
| <li> | |||
| <p>If <var>connection</var> has any stopped "sendrecv" or | |||
| "recvonly" transceivers of type <var>mediaType</var>, jump to | |||
| "recvonly" transceivers of kind <var>mediaType</var>, jump to | |||
There was a problem hiding this comment.
Maybe s/mediaType/mediaKind too? We might want to be even more specific. How about:
"recvonly" transceivers whose receiver.kind is mediaKind, jump to
?
There was a problem hiding this comment.
whose transceiver kind (with link to the definition)?
I agree that mediaKind would be more consistent language, will update.
There was a problem hiding this comment.
just kind instead of mediaKind is even more consistent :-)
There was a problem hiding this comment.
Thanks, I forgot we had the transceiver kind definition.
clarifies w3c#1672 (comment) Also changes mediaType to kind for consistency.
fippo
force-pushed
the
transceiver-kind
branch
from
2aa0559
to
cb8db92
Compare
|
squashed after some great feedback from jib :-) |
fippo
changed the title
adam-be
approved these changes
Dec 7, 2017
fluffy
approved these changes
Dec 7, 2017
|
needs rebase after #1686 |
stefhak
approved these changes
Dec 7, 2017
|
Same problem was solved in #1686, so closing this one. |
fippo
added a commit
to fippo/web-platform-tests
that referenced
this pull request
Dec 19, 2017
spec change in w3c/webrtc-pc#1681
fippo
added a commit
to fippo/web-platform-tests
that referenced
this pull request
Dec 19, 2017
spec change in w3c/webrtc-pc#1681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clarifies #1672 (comment)
Also changes mediaType to kind for consistency.