offerToReceive: Rewrite to handle two options to createOffer #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better looking diff (--patience): https://dpaste.de/heHB |
|
@fippo, sorry that this breaks some of your PRs, but it should address the problem you brought up with two options at the same time. |
fippo
reviewed
Dec 7, 2017
webrtc.html
Outdated
| "#dom-rtcpeerconnection-createoffer">createOffer</a> steps:</p> | ||
| <ol> | ||
| <li> | ||
| <p>Let <var>options</var> be the methods second argument.</p> |
There was a problem hiding this comment.
first argument? (I am glad we're dealing with the legacy callbacks elsewhere)
|
no worries, I expected that i'll have to update my PRs. This looks pretty good, I was afraid it would be more ugly! |
|
I've added an intro text and a short description of the attributes. Can you take a look @fippo Readable diff: https://dpaste.de/0jb8 |
|
Extended test to use two options: web-platform-tests/wpt#8450 |
fippo
approved these changes
Dec 7, 2017
This was referenced Dec 7, 2017
fippo
added a commit
to fippo/web-platform-tests
that referenced
this pull request
Dec 19, 2017
spec change in w3c/webrtc-pc#1686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is cleaner. Question is if we want to have a description of the individual options.