fix offerToReceive(Audio|Video): false #1683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A stab at #1586 Ironically Firefox Nightly just "broke" this: https://jsfiddle.net/dyytbfxk/ Firefox stable sets (to my surprise) the direction on all m-lines. |
|
@fippo By "broke" you mean we now implement the spec as mandated? |
|
given that the spec decided to change existing behaviour without even bothering to investigate usage (I have not seen httparchive usage data) yes. It is very much unclear how many people depend on this and the lack of feedback from consumers of the peerconnection API (both service providers and opensource library vendors) is quite concerning. |
fluffy
approved these changes
Dec 7, 2017
|
needs rebase after #1686 |
fippo
force-pushed
the
offertoreceive-false-again
branch
from
6ad1841
to
00daeb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specifies that offerToReceive* stops all non-stopped transceivers from sending.