Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have pc.close() set connection states to "closed". #1887

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Have pc.close() set connection states to "closed". #1887

merged 1 commit into from
Jun 7, 2018

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Jun 7, 2018

Fix for #1883.

henbos
henbos approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aboba aboba merged commit 0adc606 into w3c:master Jun 7, 2018
@jan-ivar jan-ivar deleted the close branch June 7, 2018 14:17
@alvestrand
Copy link
Contributor

(too late comment)
are there tests that need updating for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jan-ivar @alvestrand @henbos @aboba