Do "process removal of remote track" steps when stopping a transceiver. #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefhak
approved these changes
Jul 5, 2018
|
Relates to #1919 which has list discussion needed |
|
Opinion in the editing team is that when a transceiver is stopped, the track should end, but there's no reason to remove it from the stream. |
|
Based on what I mentioned in #1845 (comment) I think I'm still inclined to not do this. |
|
Also we typically avoid firing events on synchronous method calls (such as close()). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1812.
This is effectively very similar to #1845, the only difference being
that this PR will remove the track as soon as the transceiver is
stopped, rather than later when setLocalDescription is called.