Fire closing event #2434
Merged
Fire closing event #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fires the closing event only when close was not initiated locally. Fixes #2433
alvestrand
force-pushed
the
fire-closing-event
branch
from
3b97425
to
0be0a39
Compare
jan-ivar
approved these changes
Jan 10, 2020
webrtc.html
Outdated
| @@ -9375,7 +9375,8 @@ <h4>Closing procedure</h4> | |||
| <li> | |||
| <p>Unless the procedure was initiated by <var>channel</var>.{{RTCDataChannel/close}}, set | |||
| <var>channel</var>.<a>[[\ReadyState]]</a> to | |||
| {{RTCDataChannelState/"closing"}}.</p> | |||
| {{RTCDataChannelState/"closing"}} and <a>fire an event</a> | |||
| named "closing" at <var>channel</var></p> | |||
There was a problem hiding this comment.
Missing period.
Also, for consistency, we should use same formatting (s/"closing"/closing/) as elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fires the closing event only when close was not initiated locally.
Fixes #2433
Preview | Diff