Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire closing event #2434

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Fire closing event #2434

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be0a39
Fire closing event
alvestrand Jan 9, 2020
f00a26f
Add period and format
alvestrand Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9375,7 +9375,8 @@ <h4>Closing procedure</h4>
<li>
<p>Unless the procedure was initiated by <var>channel</var>.{{RTCDataChannel/close}}, set
<var>channel</var>.<a>[[\ReadyState]]</a> to
{{RTCDataChannelState/"closing"}}.</p>
{{RTCDataChannelState/"closing"}} and <a>fire an event</a>
named "closing" at <var>channel</var></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period.

Also, for consistency, we should use same formatting (s/"closing"/closing/) as elsewhere.

</li>
<li>
<p>Run the following steps in parallel:</p>
Expand Down Expand Up @@ -10035,12 +10036,12 @@ <h3>Garbage Collection</h3>
<p><a>[[\ReadyState]]</a> slot is
{{RTCDataChannelState/"connecting"}} and at least one event listener is registered
for <code class=event>open</code> events, <code class=event>message</code> events,
<code class=event>error</code> events, or <code class=event>close</code> events.</p>
<code class=event>error</code> events, <code class=event>closing</code> events, or <code class=event>close</code> events.</p>
</li>
<li>
<p><a>[[\ReadyState]]</a> slot is
{{RTCDataChannelState/"open"}} and at least one event listener is registered for
<code class=event>message</code> events, <code class=event>error</code> events, or
<code class=event>message</code> events, <code class=event>error</code> events, <code class=event>closing</code> events, or
<code class=event>close</code> events.</p>
</li>
<li>
Expand Down