Make sure connecting state happens whenever a ICE or DTLS transport is new #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
Oct 21, 2021
| {{RTCIceTransport}} is in the {{RTCIceTransportState/"new"}} | ||
| or {{RTCIceTransportState/"checking"}} state or any | ||
| {{RTCDtlsTransport}} is in the {{RTCDtlsTransportState/"new"}} | ||
| or {{RTCDtlsTransportState/"connecting"}} state. |
There was a problem hiding this comment.
Looks good to me, but I wonder if we can do something about the sentence structure for all of these - in normal logic, "and" has a higher precedence than "or", but it's relatively obvious that the intention here is that "None of the previous states apply" is intended to apply to all elements of the "or" clause.
Wonder if commas would help:
None of the previous states apply, and either any RTCIceTransport is in state "new" or "checking" or any RTCDtlsTransport is in state "new" or "connecting".
Unsure what's clearer - the new edit introduced a third level of logical expression. Wish English permitted parentheses!
alvestrand
approved these changes
Oct 21, 2021
dontcallmedom
added a commit
to dontcallmedom/web-platform-tests
that referenced
this pull request
Nov 15, 2023
Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting'
23 tasks
dontcallmedom
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 5, 2023
* Add test for w3c/webrtc-pc#2687 Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting' * Fix lint
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 14, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2687 (#43171) * Add test for w3c/webrtc-pc#2687 Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting' * Fix lint -- wpt-commits: ade2b4b05020a2a1d4c0504f343571fb86d12668 wpt-pr: 43171
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 16, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2687 (#43171) * Add test for w3c/webrtc-pc#2687 Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting' * Fix lint -- wpt-commits: ade2b4b05020a2a1d4c0504f343571fb86d12668 wpt-pr: 43171 UltraBlame original commit: 636375b65f5f66872b196a633b92d36e36d91480
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 16, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2687 (#43171) * Add test for w3c/webrtc-pc#2687 Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting' * Fix lint -- wpt-commits: ade2b4b05020a2a1d4c0504f343571fb86d12668 wpt-pr: 43171 UltraBlame original commit: 636375b65f5f66872b196a633b92d36e36d91480
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 16, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2687 (#43171) * Add test for w3c/webrtc-pc#2687 Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting' * Fix lint -- wpt-commits: ade2b4b05020a2a1d4c0504f343571fb86d12668 wpt-pr: 43171 UltraBlame original commit: 636375b65f5f66872b196a633b92d36e36d91480
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Dec 16, 2023
Automatic update from web-platform-tests Add test for w3c/webrtc-pc#2687 (#43171) * Add test for w3c/webrtc-pc#2687 Check that a new data channel to an unbundling endpoint makes the caller connectionState go through 'connecting' * Fix lint -- wpt-commits: ade2b4b05020a2a1d4c0504f343571fb86d12668 wpt-pr: 43171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2678
Preview | Diff