Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure connecting state happens whenever a ICE or DTLS transport is new #2687

Merged
merged 1 commit into from Oct 21, 2021
Merged

Make sure connecting state happens whenever a ICE or DTLS transport is new #2687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions webrtc.html
View file
Open in desktop
Expand Up @@ -1046,10 +1046,10 @@ <h4>
</td>
<td>
None of the previous states apply and any
{{RTCIceTransport}} is in the
{{RTCIceTransportState/"checking"}} state or any
{{RTCDtlsTransport}} is in the
{{RTCDtlsTransportState/"connecting"}} state.
{{RTCIceTransport}} is in the {{RTCIceTransportState/"new"}}
or {{RTCIceTransportState/"checking"}} state or any
{{RTCDtlsTransport}} is in the {{RTCDtlsTransportState/"new"}}
or {{RTCDtlsTransportState/"connecting"}} state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I wonder if we can do something about the sentence structure for all of these - in normal logic, "and" has a higher precedence than "or", but it's relatively obvious that the intention here is that "None of the previous states apply" is intended to apply to all elements of the "or" clause.

Wonder if commas would help:

None of the previous states apply, and either any RTCIceTransport is in state "new" or "checking" or any RTCDtlsTransport is in state "new" or "connecting".

Unsure what's clearer - the new edit introduced a third level of logical expression. Wish English permitted parentheses!

</td>
</tr>
<tr>
Expand Down