Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore comma-separated rid alternatives. #2813

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Ignore comma-separated rid alternatives. #2813

merged 2 commits into from
Jan 11, 2023

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Jan 5, 2023 •
edited by pr-preview bot
Loading

Fixes #2769. @docfaraday PTAL

Preview | Diff

@jan-ivar jan-ivar self-assigned this Jan 5, 2023
@jan-ivar
Copy link
Member Author

jan-ivar commented Jan 5, 2023

There was a choice here between removing alternatives before or after removing duplicates. I.e.

a=simulcast:recv 1,2,3;2,4,5;3,5,6

...could either reduce to:

a=simulcast:recv 1;4;6

...or

a=simulcast:recv 1;2;3

I chose the latter, because it seems sane.

@dontcallmedom dontcallmedom added the Simulcast Issue relating to Simulcast label Jan 5, 2023
@jan-ivar jan-ivar merged commit a34a4cf into w3c:main Jan 11, 2023
@jan-ivar jan-ivar deleted the alternatives branch January 11, 2023 20:24
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand Awaiting requested review from alvestrand

@aboba aboba Awaiting requested review from aboba

@youennf youennf Awaiting requested review from youennf

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate Simulcast Issue relating to Simulcast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling of simulcast attributes with multiple choices in a version seems to be underspecified
3 participants
@jan-ivar @dontcallmedom @alvestrand