Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .onicecandidateerror, for indicating ICE gathering errors #284

Merged
merged 2 commits into from
Sep 24, 2015

Conversation

juberti
Copy link
Contributor

@juberti juberti commented Aug 28, 2015

A PR based on the TPAC 2014 proposal:
https://docs.google.com/presentation/d/1nnKS9GHcOB7M1ZCHMGHRtGk9TCXBoGkISb1qIsDq2Qk/edit#

Please ignore the trailing whitespace removal.

@juberti juberti changed the title Proposal for ICE candidate gathering errors Add .onicecandidateerror, for indicating ICE gathering errors Aug 28, 2015
the STUN or TURN server.</p>
</dd>

<dt>readonly attribute unsigned short statusText</dt>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USVString not unsigned short

@martinthomson
Copy link
Member

A few nits, but otherwise ready.

@juberti
Copy link
Contributor Author

juberti commented Sep 10, 2015

Fixing nits now

@juberti
Copy link
Contributor Author

juberti commented Sep 10, 2015

PTAL

@martinthomson
Copy link
Member

It's good.

@alvestrand
Copy link
Contributor

Met with approval in Seattle. Shoudl be merged.

@alvestrand
Copy link
Contributor

The Travis error doesn't rseem like a real error. Assigning to @dontcallmedom for investigation.
If he can fix that, merging is OK.

@alvestrand alvestrand assigned dontcallmedom and unassigned juberti Sep 17, 2015
@dontcallmedom
Copy link
Member

@alvestrand Travis CI now good (had missed it in my batch of travis re-run)

alvestrand added a commit that referenced this pull request Sep 24, 2015
Add .onicecandidateerror, for indicating ICE gathering errors
@alvestrand alvestrand merged commit f87ff5a into master Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants