Adding additional members to RTCIceCandidate dictionary. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes aren't used in addIceCandidate; they're just provided in candidates signaled by onicecandidate, or retrieved from an RTCIceCandidatePair. This will allow interested applications to get more information about an ICE candidate, without parsing the candidate string.
| @@ -1271,7 +1271,9 @@ | |||
| <code>none</code>. This call will result in a change to the | |||
| connection state of the ICE Agent, and may result in a change to | |||
| media state if it results in different connectivity being | |||
| established.</p> | |||
| established. Note that the only members of the candidate attribute | |||
There was a problem hiding this comment.
I think you can remove the "note that" and just say "The only ...
| established.</p> | ||
| established. The only members of the candidate attribute | ||
| used by this method are <var>candidate</var>, <var>sdpMid</var> and | ||
| <var>sdpMLineIndex</var>; the rest are ignored.</p> |
There was a problem hiding this comment.
If sdpMid is given and sdpMLineIndex is not, what will happen?
There was a problem hiding this comment.
The same thing as before this PR, I think.
alvestrand
added a commit
that referenced
this pull request
Oct 15, 2015
Adding additional members to RTCIceCandidate dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes aren't used in addIceCandidate; they're just provided
in candidates signaled by onicecandidate, or retrieved from an
RTCIceCandidatePair. This will allow interested applications to get more
information about an ICE candidate, without parsing the candidate
string.
This is the change Peter suggested, which we agreed to at the Redmond f2f.