Update JSEP reference in RTCIceTransportState definition #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
Jan 12, 2017
| as described in [[!JSEP]].</p> | ||
| <code>false</code>, or the processing of an end-of-candidates | ||
| indication as described | ||
| in <span data-jsep="addicecandidate">[[!JSEP]]</span>.</p> |
There was a problem hiding this comment.
As I read JSEP at the moment, the end-of-candidates indication is the same as calling with a candidate value whose candidate property is the empty string, so this is saying the same thing twice.
There was a problem hiding this comment.
So the truth is that I still don't believe JSEP anywhere actually describes processing of an end-of-candidates indication but do believe that I'm never going to get a proper answer on that, so I almost deleted the reference to JSEP altogether. I am happy to delete everything from ', or the processing . . .' onwards.
There was a problem hiding this comment.
Deleting everythign after the comma would work for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #723.